Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sim): add Sky130CommercialSchema and simplify trait bounds #351

Merged
merged 3 commits into from
Dec 23, 2023

Conversation

rohanku
Copy link
Contributor

@rohanku rohanku commented Dec 23, 2023

No description provided.

Copy link

codecov bot commented Dec 23, 2023

Codecov Report

Attention: 50 lines in your changes are missing coverage. Please review.

Comparison is base (2f9fabf) 39.40% compared to head (6a41d9b) 39.18%.

Files Patch % Lines
pdks/sky130pdk/src/lib.rs 12.28% 45 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   39.40%   39.18%   -0.23%     
==========================================
  Files         162      162              
  Lines       20014    20068      +54     
  Branches     8388     8405      +17     
==========================================
- Hits         7887     7864      -23     
- Misses       6659     6708      +49     
- Partials     5468     5496      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohanku rohanku merged commit c95e5c0 into main Dec 23, 2023
5 checks passed
@rohanku rohanku deleted the sim-api-updates branch December 23, 2023 03:22
@rohanku rohanku mentioned this pull request Dec 22, 2023
This was referenced Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants